CollapseLauncher / Collapse

An Advanced Launcher for miHoYo/HoYoverse Games
MIT License
1.4k stars 64 forks source link

[Bug]: Unhandled Error when manually checking for updates in 1.82.0 Preview #599

Closed Cactism closed 2 weeks ago

Cactism commented 2 weeks ago

Affected Version

Collapse 1.82.0 Preview

Bug Behavior

After clicking the "Check for Update" button in Collapse's settings, an error will appear. image

Expected Behavior

Collapse should be able to check for updates, like in the latest stable build image

Steps to reproduce

  1. While using 1.82.0 Preview, open Collapse's settings panel
  2. Check for updates

Related Issues

No response

Screenshot(s)

No response

Additional Information

I've already tried using a fresh installation of the Preview build, with the same error.

neon-nyan commented 2 weeks ago

Thank you for reporting this bug. Seems like the Update status returns a null when an update is not available, but somehow we forgot to handle or show an "Up-to-date" message when no update is available.

Should be fixed in the next preview/later stable release and it shouldn't affect update mechanism once a new update is coming.

bagusnl commented 2 weeks ago

Fixed in https://github.com/CollapseLauncher/Collapse/commit/b4b883282ca12e2344710bad8ef502e323560160

bagusnl commented 2 weeks ago

Fix pushed to 1.82.1 Thanks for reporting the issue