bagusnl commented 1 year ago

Some QOL suggestions regarding CL as a whole to make experience using CL better for more users.

General

[ ] Add option to symlink AppData C:\Users\bagusnl_reg\AppData\LocalLow\miHoYo to the same folder as Collapse data to make it possible to share AppData between systems (making portable version not needing to download caches every time).

[x] Move main config.ini to be in the same place as launcher folder for easier debugging and easier portable config.

[ ] When possible, use relative folder path instead of static in case of drive letter change.

[x] Make it possible to run 2 (or more) instance of Collapse. This will help with #44 while better implementation is in the work. To prevent 2 instance of a game conflicting, make it so that 2 instance of the launchers can't be in the same active region (perhaps with PID file indicating current state of said launcher status).

[x] #501 .

[ ] Add an option to have current active Game Logo (+region) when using custom background.

[x] Retain previous region selection when switching back from another game.

[x] Add option to disable social side bar.

[x] Unify the order of social side bar between games.

[x] Add Discord RPC to indicate the status of the app (playing, updating, repairing, etc) (Next major release after 1.69 most likely)

[x] Investigate whether or not having a confirmation button is necessary when changing regions in the same game

[x] Implement launching Collapse on Windows start

[x] Implement tray icon for Collapse, ~~with the "X" button presenting a dialog for choosing to close or minimize to tray.~~ TrayIcon implemented, using Minimize button to hook, while having the option to choose on settings page.

Honkai Impact

[x] Differentiate side bar "Game Settings" with main page "Game Settings". Maybe change main page "Game Settings" as "Quick Settings" since its being used in that menu too?

[x] #467

[ ] Implement hoyolab-rss-feeds for the missing Honkai Impact 3rd Events Panel.

Genshin Impact

[x] Implement Game Settings like HI3, reading from registry.

[ ] Add feature to manage installed VO Language (similar to in-game settings).

[x] Add shortcut to community-made tools such as paimon.moe (web), official GI hoyolab map (web), genshin-calculator (web), Inventory Kamera (app), etc.

[ ] Implement maintenance detection outside of game

neon-nyan commented 1 year ago

Thank you for all these QoL suggestions and sorry for my very late response on this because there are lots of consideration for this one but most of them are possible to be implemented. The only thing we need is just some people who could help me to implement all of these features.

But of course, there are some suggestions that I'm worried it's not possible to be implemented soon (at least for now) or some question about it, which are:

General

When possible, use relative folder path instead of static in case of drive letter change.

The problem of using relative path instead of absolute path is related with the mechanism of how the launcher will decide which drive to be used. Yes, this will be useful if you're deciding to use the same drive to store the launcher files as where the launcher installed. But if you have a custom path to store the launcher, this would have some confusion to how the launcher will read the path. I don't say that this is impossible to do but if anyone want to work on this approach, I will be appreciate it.
Unify the order of social side bar between games.

Not sure if I understand that. Could you describe it more?
Add Discord RPC to indicate the status of the app (playing, updating, repairing, etc)

Might be implementing it in the future but I will put this as low priority.

I might leave another concerns here but that's all for now.

neon-nyan commented 1 year ago

General

Make it possible to run 2 (or more) instance of Collapse. This will help with #44 while better implementation is in the work. To prevent 2 instance of a game conflicting, make it so that 2 instance of the launchers can't be in the same active region (perhaps with PID file indicating current state of said launcher status).

This has been completed as per latest commit: https://github.com/neon-nyan/Collapse/commit/c328d8e468bbff90d522c7ca17beaaf3e8f58882

bagusnl commented 1 year ago

Unify the order of social side bar between games.

Not sure if I understand that. Could you describe it more?

its this bar on the right, the order isn't the same between GI and HI3

It would be nice if it has similar order like this

Game homepage
HoyoLab
Twitter
Reddit
Facebook
YouTube ...etc

Yes, this will be useful if you're deciding to use the same drive to store the launcher files as where the launcher installed. But if you have a custom path to store the launcher, this would have some confusion to how the launcher will read the path.

I guess checking if the CL and Game is in the same drive before deciding it will do a relative path or static path would be not an ideal solution. I'm still thinking on how it can be done too

neon-nyan commented 1 year ago

its this bar on the right, the order isn't the same between GI and HI3

It would be nice if it has similar order like this

Game homepage

HoyoLab

Twitter

Reddit

Facebook

YouTube ...etc

~~Okay, got it! This should be applicable by using a simple sort.~~

EDIT [21/02/2023]:

After finding out, most of each social media buttons don't have some tag to be used for sorting. That means, it's not applicable.

EDIT [05/03/2023]:

The sort can be done (at least for now) by URL.

neon-nyan commented 1 year ago

Differentiate side bar "Game Settings" with main page "Game Settings". Maybe change main page "Game Settings" as "Quick Settings" since its being used in that menu too?

This one has been renamed from Game Settings to "Quick Settings"