ColorlibHQ / illdy

Illdy is a free one page WordPress business theme with a minimal design
GNU General Public License v3.0
44 stars 38 forks source link

[Illdy] Parralax Section For FrontPage widget does not display images #210

Closed vinoddalvi closed 7 years ago

vinoddalvi commented 7 years ago

[Illdy] Parralax Section For FrontPage widget does not display images if set its Image Position to background full or small. The image displays in admin area customizer but not in front end.

cristianraiber commented 7 years ago

@giucu91 - please see this.

giucu91 commented 7 years ago

Hello @vinoddalvi,

Can you please give me more details, because I've just tested the Illdy widget and it works ok. https://georgeciobanu.com/sandobx/ -> the last section is [Illdy] Parralax Section For FrontPage widget.

Here are the settings for widget in backend : illdy-widget

vinoddalvi commented 7 years ago

You have configured the widget correctly. Just make sure you are using theme and illdy-companion plugin versions from wp.org and not from github.

I troubleshooted it more and found the z-index is causing this issue for me as shown in the below attached screenshots. screenshot 19 screenshot 20

cristianraiber commented 7 years ago

@vinoddalvi - please pull the latest version of Illdy from here: https://github.com/MachoThemes/illdy && https://github.com/MachoThemes/illdy-companion and test to make sure this has been implemented correctly.

Please report back your findings in this ticket so we can close/update it after testing.

vinoddalvi commented 7 years ago

I tested it importing theme and plugin from github.

I configured the widget as shown in the attached screenshot. screenshot 16

When i add the widget in Blog Sidebar Widget area then i get the result as below. screenshot 18

When i add the widget in FrontPage Sidebar Widget area then i get the result as below. screenshot 17

It seems this is still not working fine.

cristianraiber commented 7 years ago

@giucu91 - please see this.

giucu91 commented 7 years ago

@vinoddalvi - can you please pull the updates now? It should be fixed.

Thanks, George.

vinoddalvi commented 7 years ago

Now in the Blog Sidebar Widget area it doesn't display at all and in the Front pages widget area it displays as shown in the below screenshot.

screenshot 5

Is this expected result?

If not then after fixing the issue could you please also share me the screenshot of it from your test site?

cristianraiber commented 7 years ago

@vinoddalvi - these widgets should have never showed up for usage in blog sidebar / footer areas. We've added a filter to unlist them from those places as their intended purpose was to be used to create the front-page sections.

vinoddalvi commented 7 years ago

@cristianraiber Ok understood thank you.

What about the output on front page widget area? Is it intended?

cristianraiber commented 7 years ago

@vinoddalvi - this only displays as full-width when used in the "Full-width" section. So, yes, what you're currently seeing is absolutely fine :)

vinoddalvi commented 7 years ago

What do you mean by full width section here so that i can test it?

cristianraiber commented 7 years ago

@vinoddalvi

image

vinoddalvi commented 7 years ago

@cristianraiber That is what i have tested on my site.

screenshot 7

cristianraiber commented 7 years ago

@vinoddalvi - add this widget to the "Full width section". It should behave as expected there. You're currently placing it in the wrong place :)

vinoddalvi commented 7 years ago

Glad it worked in the Full Width Section as displayed below but didn't see any difference between Image position "Background Full" and "Background Small".

screenshot 8

giucu91 commented 7 years ago

Hello @vinoddalvi , the parallax widget is designed for full width sections as @cristianraiber mentioned. But you can add this widget also on about/projects/testimonials/team/services but in these sidebars the widgets' width it's not 100%, this is how the theme was implemented.

Hope this makes sense.

If everything is ok can i go ahead and close this ticket ?

giucu91 commented 7 years ago

Sorry, I didn't see the issue about the small and full background, I'll let you know when this is ready.

Thank you for your understanding, George.

vinoddalvi commented 7 years ago

@giucu91 Not an issue. You are doing great work.

Do let me know when you fix the issue about the small and full background so that i can test it.

giucu91 commented 7 years ago

Hello @vinoddalvi , the issue is solved, can you check it now ?

vinoddalvi commented 7 years ago

Tested it's working fine.

Great work...!!