search

ColorlibHQ / illdy

Illdy is a free one page WordPress business theme with a minimal design
GNU General Public License v3.0
44 stars 38 forks source link

MT_Notify_System::illdy_has_posts: "Gary Johns: 'What is Aleppo'" #252

Closed ossie closed 6 years ago

ossie commented 6 years ago

I'm not sure about the purpose of MT_Notify_System::illdy_has_posts: There is a search for posts with the string "Gary Johns: 'What is Aleppo'" in here. Seems a little bit too specific to me.

cristianraiber commented 6 years ago

@ossie - the purpose of that check is to verify that the demo content has successfully been imported :) Basically, we're looking for something really specific that can be found only in our demo content.

ossie commented 6 years ago

Well, it adds an extra SQL query on every page load through the Illdy constructor.

cristianraiber commented 6 years ago

That goes away after and/if you've imported our demo content. Should probably check only once, most likely it's not hooked properly right now. cc @giucu91

cristianraiber commented 6 years ago

@ossie - just FYI this thas been removed in the upcoming update. You can see the change here: https://github.com/MachoThemes/illdy/commit/7356c837150c6c06e08c485e3cbbb293982c3956#diff-6eb635034da20e8c915a61129bf31f53L41.

Thank you so much for reporting this and helping us improve Illdy. Your report is highly appreciated.

Cristian.

ossie commented 6 years ago

You are wolcome.