Correction to Bootstrap Grid system

ColorlibHQ / illdy

Illdy is a free one page WordPress business theme with a minimal design

GNU General Public License v3.0

44 stars 38 forks source link

Correction to Bootstrap Grid system #308

Closed foxysolutions closed 3 years ago

foxysolutions commented 4 years ago

Updated both bootstrap.css and bootstrap.min.css to correctly follow current Bootstrap GRID documentation (https://getbootstrap.com/docs/4.0/layout/grid/#grid-options)
Corrected sm, md and lg and introduced xl
Tried to upgrade to bootstrap 4.0.0 but that caused trouble with many parts in Theme

foxysolutions commented 4 years ago

@cristianraiber is there a reason this PR got closed?

cristianraiber commented 4 years ago

cc @razvanaldea89

mahendrapratap4022 commented 3 years ago

Hi @foxysolutions Thanks for the PR I know that it is quite late to review the PR sorry about that. I reviewed the code and found out that it is breaking after 752px other than that all things working fine I would fix this issue and approve this PR
but right now we are planning to go ahead with version 5 so soon we will release a new version who support the bootstrap 5 so we don't have to do it manually. You made a great effort thanks! 👍🏻