search

Comcast / gots

MPEG Transport Stream handling in Go
Other
308 stars 88 forks source link

Fix out of bounds access #165

Closed tmm1 closed 2 years ago

tmm1 commented 2 years ago 

runtime.boundsError: runtime error: index out of range [6] with length 6
  File "github.com/Comcast/gots@v0.0.0-20201111000122-5e29012f8ad4/pes/pesheader.go", line 180, in NewPESHeader
tmm1 commented 2 years ago

what's the deal with the v2 directory? does something sync changes over automatically, or should i be updating both places in my PRs?

LimitlessEarth commented 2 years ago

Ah yes, we should probably port this into there as well. Golang modules require these shenanigans with their semver to work. I really dislike it. Because this library was already above v2.x.x we needed to make that stupid v2 version/folder to allow this library to work at all with go modules.

Yo dawg, I heard you like versioning, so in your versioning system we versioned your version so you can download that versioned version from the versioning system.

https://github.com/Comcast/gots/issues/141

Read more here: https://go.dev/blog/v2-go-modules