Add Interstitial Tag Support - Githubissues

Comcast / mamba

Mamba is a Swift iOS, tvOS and macOS framework to parse, validate and write HTTP Live Streaming (HLS) data.

Apache License 2.0

182 stars 40 forks source link

Add Interstitial Tag Support #144

Closed rmigneco closed 3 weeks ago

rmigneco commented 1 month ago

Description

This PR adds support for Interstitial Tag Attributes as outlined in the Appendix D of the HLS Spec

Change Notes

Adds PantosValue attributes to support interstitials
Updates the EXT_X_DATERANGETagValidator to include additional values and include specific validation rules for HLS Interstitials
Adds unit tests for the new validation rules
Creates HLSInterstitialValues to represent the attribute options
Creates InterstitialTagBuilder which facilitates creating a HLSTag type configured specifically for interstitials
Unit tests for InterstitialTagBuilder

Pre-submission Checklist

[x] I ran the unit tests locally before checking in.
[x] I made sure there were no compiler warnings before checking in.
[x] I have written useful documentation for all public code.
[x] I have written unit tests for this new feature.

rmigneco commented 3 weeks ago

Looks good! Just some small comments and questions.

@theRealRobG got your changes incorporated - LMK if you'd like to get this into 2.0 as well