Comfy-Org / comfy-cli

Command Line Interface for Managing ComfyUI
https://docs.comfy.org/comfy-cli/getting-started
GNU General Public License v3.0
291 stars 47 forks source link

added support for ruff linting and autoformatting #149

Closed telamonian closed 3 months ago

huchenlei commented 3 months ago

Are we nuking the current setup of linting with pylint and autoformatting with black?

telamonian commented 3 months ago

Are we nuking the current setup of linting with pylint and autoformatting with black?

@huchenlei That's the idea. ruff alone can handle both linting and formatting (it has tools for both). It should also support more features/rules and be much more flexible than black.

Oh, and also be much faster, thanks to the fact that it's written in rust. The only real downside that I can think of is that, being written in rust, it will be harder for us to contribute back upstream. Which hopefully shouldn't be too relevant for us

socket-security[bot] commented 3 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/ruff@0.6.1 environment, eval, filesystem, network, shell, unsafe 0 32.8 MB astral-bot, crmarsh, zanie

View full report↗︎

socket-security[bot] commented 3 months ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1, pypi/ruff@0.6.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

telamonian commented 3 months ago

@SocketSecurity ignore pypi/ruff@0.6.1

telamonian commented 3 months ago

No need to worry about the failure of the ruff_check GA, that gets fixed when the initial ruff lint/format is applied in #157