Comfy-Org / comfy-cli

Command Line Interface for Managing ComfyUI
https://docs.comfy.org/comfy-cli/getting-started
GNU General Public License v3.0
291 stars 47 forks source link

comfyui install-deps fail without error output #159

Open kobechenyang opened 3 months ago

kobechenyang commented 3 months ago

Describe the bug comfy node install-deps --workflow failed without any error

render@b30981f96736:~/ComfyUI$ comfy node simple-show installed
Execute from: /home/render/ComfyUI
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
ComfyUI-Manager                                   
comfyui-tooling-nodes                             
x-flux-comfyui                                    

render@b30981f96736:~/ComfyUI$ comfy node install-deps --deps=workflow_dependency.json 
Execute from: /home/render/ComfyUI
Current snapshot is saved as `2024-08-21_21-25-38_cli-autosave.json`
Install: ['https://github.com/Fannovel16/comfyui_controlnet_aux']
Download: git clone 'https://github.com/Fannovel16/comfyui_controlnet_aux'
Dependency installation and activation complete.

render@b30981f96736:~/ComfyUI$ comfy node simple-show installed
Execute from: /home/render/ComfyUI
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
ComfyUI-Manager                                   
comfyui-tooling-nodes                             
x-flux-comfyui                                    

I have 3 dependencies in my workflow

{
    "custom_nodes": {
        "https://github.com/Acly/comfyui-tooling-nodes": {
            "state": "installed",
            "hash": "-"
        },
        "https://github.com/XLabs-AI/x-flux-comfyui": {
            "state": "installed",
            "hash": "-"
        },
        "https://github.com/Fannovel16/comfyui_controlnet_aux": {
            "state": "installed",
            "hash": "-"
        }
    },
    "unknown_nodes": []
}

What I found out later that the git clone was throwing a https error. comfy node install package-name was able to throw the correct error

render@b30981f96736:~/ComfyUI$ comfy node install comfyui_controlnet_aux
Execute from: /home/render/ComfyUI
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
[1/1] Install: ['https://github.com/Fannovel16/comfyui_controlnet_aux']
Download: git clone 'https://github.com/Fannovel16/comfyui_controlnet_aux'
ERROR: An error occurred while installing 'comfyui_controlnet_aux'.

To Reproduce

FROM nvidia/cuda:12.3.1-runtime-ubuntu22.04
RUN apt-get update && \
    DEBIAN_FRONTEND=noninteractive apt-get install -y \
    bash \
    sudo \
    python3 \
    python3-pip \
    git \
    wget \
    rm -rf /var/lib/apt/lists/*
RUN pip install comfy-cli
RUN comfy node install-deps --deps=

Expected behavior It will be nice to output errors from comfy node install-deps command.