[Core, ServerSide] Unused AndroidX AppCompat dependency?

MGaetan89 commented 2 weeks ago

We were looking at our project dependencies and noticed that CommandersAct's Core and ServerSide modules were pulling in a dependency on AndroidX AppCompat 1.4.1 (as documented in each module's README file: Core and ServerSide). However, we think that this dependency is not used. Since it's quite a big dependency, would it be possible to investigate if it is indeed necessary? There may be smaller packages that can be used instead (AndroidX Annotation, AndroidX Lifecycle, ...). There are Gradle plugins that can help you keep a clean list of dependencies on your modules (for example, autonomousapps/dependency-analysis-gradle-plugin).

Also, AndroidX Ads has been deprecated in version 1.0.0-alpha05. Instead, it is recommended to use Play Services' Advertising ID API. Migrating to the new recommended solution would allow moving away from Guava.

CommandersAct commented 2 weeks ago

Hello ! We checked and it is used in Core but not in Server-Side anymore. I have some task to clean useless protection against SDK versions but I think it will still be a bit needed in Core anyway.

As for Ads it's planned to be replaced but it's not our current priority.

MGaetan89 commented 1 week ago

I see that new versions have been released today, with updates to the dependencies. Thanks for the quick follow-up on this topic!

Core

AndroidX AppCompat is still a dependency, as you mentioned, it's used internally. But it has been updated to 1.6.1.

ServerSide

AndroidX AppCompat has been removed 👍🏻
AndroidX Ads has been migrated to Play Services Ads Identifier 👍🏻
Guava is still a dependency, maybe it's still necessary.

CommandersAct / AndroidV5

[Core, ServerSide] Unused AndroidX AppCompat dependency? #9