CommunityToolkit / Graph-Controls

Set of Helpers and Controls for Windows development using the Microsoft Graph.
https://docs.microsoft.com/en-us/windows/communitytoolkit/graph/overview
Other
155 stars 39 forks source link

Adjusted uwp project files to match WCT. #118

Closed shweaver-MSFT closed 3 years ago

shweaver-MSFT commented 3 years ago

Also updated some broken tests after provider event name change, and a bug in the LoginButton.

PR Type

What kind of change does this PR introduce?

What is the current behavior?

WCT uses a special csproj format for UWP projects, and the Graph-Controls repo should match.

Here is an example from WCT: https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/main/Microsoft.Toolkit.Uwp.UI.Controls.Input/Microsoft.Toolkit.Uwp.UI.Controls.Input.csproj

What is the new behavior?

The csproj formats in the following packages now match the way WCT handles UWP projects:

  1. CommunityToolkit.Authentication.Uwp
  2. CommunityToolkit.Graph.Uwp

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

ghost commented 3 years ago

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌