search

CommunityToolkit / Graph-Controls

Set of Helpers and Controls for Windows development using the Microsoft Graph.
https://docs.microsoft.com/en-us/windows/communitytoolkit/graph/overview
Other
155 stars 39 forks source link

Experimental attribute for GraphPresenter and sample updates #148

Closed shweaver-MSFT closed 3 years ago

shweaver-MSFT commented 3 years ago

Fixes #55

PR Type

What kind of change does this PR introduce?

What is the current behavior?

We are getting close to release, and the GraphPresenter is not quite completed. There are a few additional features to add and scenarios to test before it will be ready for regular use.

Also, the sample app has several GraphPresenter samples, but they are all sharing the same file. This makes it a bit harder to read the code.

What is the new behavior?

I've added the Experimental attribute to the GraphPresenter and associated QueryOption classes. This warns developers who choose to consume them.

Next, I've taken the existing GraphPresenter sub-samples and moved them into individual pages in their own folder. This cleans up the sample a bit and makes it easier to see each sample in isolation and understand how it works.

Lastly, I've added an additional GraphPresenter sub-sample for OneDrive as detailed in #55.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

ghost commented 3 years ago

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

shweaver-MSFT commented 3 years ago

@michael-hawker added you in case you are curious. This was based on your sample in #55. It works great! Pretty easy to drop in and make a few adjustments 😊

michael-hawker commented 3 years ago

Yeah, I'll pull things down tomorrow and give it a spin. Excited to check out all the sample updates. 🎉

michael-hawker commented 3 years ago

Ah, we're not running the unit tests in the CI, eh?

Looks like we forgot to update some tests with namespace changes?

image

michael-hawker commented 3 years ago

~Hmm, got an "Exception = {"The operation was canceled."}" when trying to run the sample.~

Edit: Cleaned and rebuilt seemed to work.

michael-hawker commented 3 years ago

When switching to the PeoplePicker page:

image

michael-hawker commented 3 years ago

Try testing out some of the other samples, got a scope exception and seeing some index exceptions eaten internally somewhere. But otherwise looking great! 🎉

shweaver-MSFT commented 3 years ago

@michael-hawker weird exception, I haven't seen that myself. I'll see if I can play around and get it to repro.

I'll also get those tests updated 👍

shweaver-MSFT commented 3 years ago

I'm not sure about the exception, so I've logged bug #149

I have a hunch that the issue is in TokeninzingTextBox and not in the PeoplePicker itself.