Support for dotnet core

ComparetheMarket / fettle

An experimental mutation testing tool for C# code :bug::mag:

MIT License

66 stars 10 forks source link

Support for dotnet core #5

Open oliwennell opened 6 years ago

oliwennell commented 6 years ago

Investigate what's required.

Known issues:

We assume Windows style directory separators (C:\blah) - for this should be able to cherry-pick https://github.com/ComparetheMarket/fettle/commit/b7efed34e91b93d4b5be1d112d4b01fa77bd5285 from the mono branch
MSBuildWorkspace not available

Known potential issues:

Relying on app-domains for isolation when running tests using NUnit Engine, not sure what happens when using the .NET Standard version?

dcook-net commented 5 years ago

@oliwennell do you want a hand with this? I was just thinking about it this morning....which is how I found this issue.

oliwennell commented 5 years ago

I'd welcome your help if you're up for it @dcook-net :)

I did some initial investigation but i was quite a while ago now. Perhaps if you have an initial look and we can talk through what you find?

dcook-net commented 5 years ago

Cloning...

robertlyson commented 5 years ago

Just thought about creating a global tool for fettle, so we could simplify how the tool is run. And this is how I landed here. @dcook-net how it went with conversion to the core? Can I help somehow?

robertlyson commented 5 years ago

Support for Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace(https://github.com/dotnet/roslyn/issues/17974) is missing in core.

dcook-net commented 5 years ago

@robertlyson I didnt get very far, mostly due to other commitments tbh. I doesn't currently build.

oliwennell commented 5 years ago

Hey @robertlyson , thank you for offering to help :) 👍

Right now what would help is a list of "known issues" that we need to resolve before we can support dotnet core. I see that you've mentioned an issue with MSBuildWorkspace, if you're able to find out any others and list them here that's be great.

Alternatively, you could look into how we could get around the MSBuildWorkspace issue you mentioned.

dcook-net commented 5 years ago

Just thought about creating a global tool for fettle, so we could simplify how the tool is run. And this is how I landed here.

@robertlyson This is a good idea. Personally I think this combined with DotNetCliToolReference support would be fantastic (FYI - this is also how Stryker works). This would give users complete flexibility in how people consume fettle. Global Tools are great on the command line, but are a little messy inside Docker. Just thinking out load.