Fix copying an `OpenSim::Model` with an `OpenSim::ExternalLoads` isn't possible

ComputationalBiomechanicsLab / opensim-creator

A UI for building OpenSim models

https://opensimcreator.com

Apache License 2.0

155 stars 18 forks source link

Fix copying an `OpenSim::Model` with an `OpenSim::ExternalLoads` isn't possible #924

Closed adamkewley closed 1 month ago

adamkewley commented 1 month ago

Appears to be a bug in the OpenSim API: the OpenSim::ExternalLoads is typically built from an XML file, which is then listed as the associated document in the OpenSim::Object. The associated document is wiped every time the object is copied, which then makes reinitialization fail.

adamkewley commented 1 month ago

Verified as fixed after applying the upstream fixes via a cherry-pick. We can use the cherry-picked commits until upstream merges.