search

ComputerScienceHouse / bingehack

A fork of nethack with semi-multiplayer features and other customizations. (An in-heavy-development fork version is at https://github.com/computersciencehouse/bingehack4 )
http://nethack.csh.rit.edu
23 stars 4 forks source link

Add Achievements #14

Closed clockfort closed 13 years ago

clockfort commented 14 years ago

Because nethack belongs on xbox arcade. Or steam.

eatnumber1 commented 14 years ago

The achievements should apply to the user's account, and not any one game.

clockfort commented 14 years ago

Of course. Probably going to plop them in a file in the users' pseudo-home directory thing we have going, with all off their other data (i.e. ttyrecs, nethackrc, etc)

clockfort commented 14 years ago

Achievement idea: Put a "statue/figurine of a gnome" (lawn gnome) in Potter's Brandreth garden. If the player carries it through all the levels, and ascends with it, a la Half Life 2: Episode 2, he unlocks an achievement. :-)

eatnumber1 commented 13 years ago

Grantovich is working on the actual implementation of these achievements in the "more_achievements" branch.

Grantovich, is the code ready to merge?

digitalcora commented 13 years ago

Most of it is still untested, so not yet. I'm going to attempt to implement and test a majority of the achievements by the time of the binge. I may not get all the way there, but I'll test as I go, so whatever ends up in the more_achievements branch on Friday night should be merge-ready.

digitalcora commented 13 years ago

Also, you should probably remove the #testmail command from the live code, so people can't trivially award themselves an achievement. =p

clockfort commented 13 years ago

Yeah, it'd be nice if someone took that code I wrote and let it only work in Wizard mode, along with all of the other crazy testing commands in that mode.

digitalcora commented 13 years ago

More like you are going to take that code you wrote and let it only work in Wizard mode. Because you wrote it. And it's probably an absurdly trivial change, even by your laziness standards.

clockfort commented 13 years ago

Pshhhhhh how about I impress you and actually finish the features I have test commands for :-P

clockfort commented 13 years ago

4e5eb10e1c2d77bf167ca79d8736e8253db8a537 BITCHES

digitalcora commented 13 years ago

...you still didn't fix #testmail. ಠ_ಠ

clockfort commented 13 years ago

Blah blah blah

clockfort commented 13 years ago

Fixed in 5fb6d38d872b9f0e83e7ebe301b450f61fcd483b + 5b1a29608367b82ee31fa9996053127c8f2cd763.

Now integrate your stuff in for the binge :-P

digitalcora commented 13 years ago

Current achievement implementation progress: 30/80

(total is not counting the three achievements awarded for out-of-game activities)

digitalcora commented 13 years ago

New achievement progress: 40/80

Small increment because I was busy today, and intentionally did some harder ones. Should still be able to get them all done by the end of tomorrow.

digitalcora commented 13 years ago

New achievement progress: 54/76 (22 remaining)

Four achievements were knocked off the total because they seem (at least to me) to be impossible to implement without major code changes. Fortunately, all but one of them would probably not be achieved by the average binge player anyway.

The remaining 22 are all the artifact and conduct achievements, so this should go pretty fast. I might even have time to toss in a few new ones while I'm at it. =D

digitalcora commented 13 years ago

All 76 achievements are now implemented (and lightly tested) in ebee605928639046eb28d4e56a13bfc865764ea3. I may do a few more before the binge, but feel free to merge the more_achievements branch now.

eatnumber1 commented 13 years ago

This has been merged into mainline and pushed to production. Thanks @grantovich.