search

ComputerScienceHouse / bingehack

A fork of nethack with semi-multiplayer features and other customizations. (An in-heavy-development fork version is at https://github.com/computersciencehouse/bingehack4 )
http://nethack.csh.rit.edu
23 stars 4 forks source link

Compiling Nethack with the latest GCC produces warnings #23

Closed eatnumber1 closed 14 years ago

eatnumber1 commented 14 years ago

Compiling Nethack with the latest GCC produces a metric fuckton of warnings.

clockfort commented 14 years ago

I think Nethack with any GCC produces a metrick fuckton of warnings. A lot of the code might be written the way it is to provide compatibility with other compilers though... ... we're not writing CSH Nethack for Amiga or OpenVMS, though, so, if it makes you sleep better at night, feel free to weed through the code and pluck out the warnings. Just try not to introduce new bugs :-)

eatnumber1 commented 14 years ago

As of SHA: 39506b34b1c0dd6f57b11b6dfd82871833f6f378 Nethack compiles without warnings under gcc 4.3.2. Nethack also now compiles with -Wall -Werror which causes all warnings to be treated as errors. As part of the work to remove the errors, Nethack also now compiles in c99 mode (-std=c99)