ConnorConquers / Queertorio

Be gay, kill bugs.
20 stars 1 forks source link

Upload actual source code instead of a zip file #3

Open glektarssza opened 2 weeks ago

glektarssza commented 2 weeks ago

Generally you should upload the actual mod source code instead of the bundled zip file. While it's not strictly bad form to upload a zip file it's definitely going to dissuade some people from grabbing your mod for a variety of reasons (e.g. security concerns).

glektarssza commented 2 weeks ago

Actually, having looked at the contents of the zip file I know question if the reason you uploaded a zip file was instead driven by intent to deceive instead of some kind of ignorance...

This mod does not actually do anything. It adds two settings:

Both of these settings have no impact on gameplay. Furthermore, your own info.json file admits that this mod is made "out of spite".

{
    "name": "queertorio",
    "version": "1.0.0",
    "factorio_version": "1.1",
    "title": "Queertorio",
    "author": "ConnorConquers",
    "description": "Adds LGBQT options to the game. Mostly out of spite :)"
  }

The above is the entirety of the contents of the zip file besides for the icon image. That's it. There's nothing else. Anyone could put this mod together in about 5-10 minutes with minimal effort but in your YouTube video you play it off as if you learned Lua and that was a huge effort in order to make a mod to fight back against the lead Factorio developer's questionable social media history.

I highly doubt you actually understand what the code you wrote does or how it works based on the names you used for the settings themselves (my_custom_feature_enabled and my_dropdown_setting).