search

ConnorFTW / discord-bot-creator

Create your Discord bot in less than 30 minutes.
https://discord-bot-creator.app/
Other
20 stars 5 forks source link

(JS-0463) Consider adding `propTypes` to the React component definition #18

Closed m5x5 closed 2 years ago

m5x5 commented 2 years ago

Description

It is recommended to always add propTypes for a component as it avoids runtime errors. Using propTypes ensures valid properties being passed as props or being used as props.

Occurrences

There are 29 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/Michael55555/discord-bot-creator/issue/JS-0463/occurrences/

jbbn commented 2 years ago

Hey @Michael55555, I can do that 🙌

m5x5 commented 2 years ago

Awesome, thanks for your engagement! ✨

rajoriaakash commented 2 years ago

Hi, can I take a look at this too?

m5x5 commented 2 years ago

I thought it might be better to give @jbbn a chance at this first. Would you like to work on #10 instead maybe, or shall I find you something more in the field of improving syntax like this issue? 😃

rajoriaakash commented 2 years ago

From what I understand, to solve #10 I would really need to understand the full code and it will take a lot of time for me to do that :) or am I missing something?

jbbn commented 2 years ago

yep, I am almost done with the changes 👍