search

Consensys / armlet

a MythX API client wrapper
MIT License
16 stars 7 forks source link

[bug fix] timeout of analysisMode is never used and the logic looks w… #79

Closed tagomaru closed 5 years ago

tagomaru commented 5 years ago

Looks like that timeout based on analysisMode is never used and the login is wrong. Do you check whether this is the logic you assumed originally?

And comment for initialDelay looks wrong.

tagomaru commented 5 years ago

@rocky Yeah, and original logic seemed to set small timeout to options.timeout because (60 * 1000) is never multiplied.

rocky commented 5 years ago

@tagomaru The test failing on CircleCI seem to be as a result of doing a PR from a fork.