Closed rocky closed 5 years ago
rocky
commented
5 years ago @daniyarchambylov I yet again skipped numerous tests because of a needed interface change.
The unit tests should be reinstated, so if you would do that, I would appreciate it.
This test code needs DRYing. You shouldn't have to change 15 or so places when an interface changes, but ideally something like 1-4 places.
coveralls
commented
5 years ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/analysisPoller.js | 10 | 16 | 62.5% | ||
| <!-- | Total: | 13 | 19 | 68.42% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| lib/analysisPoller.js | 1 | 72.94% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 401: | -0.8% |
| Covered Lines: | 250 |
| Relevant Lines: | 313 |
I think handling refresh here has been broken from the very beginning, even in the times it was called "poller.js".
We never noticed this before, because another misfeature caused many unecessary logins to occur. Therefore we never really ran into running refresh. Since that was fixed, this latent bug surfaced.