Reenable Tx Outcome Checks

Consensys / linea-tracer

Part of the Linea stack responsible for extracting data from the execution of an EVM client in order to construct large matrices called execution traces.

https://linea.build

Other

35 stars 26 forks source link

Reenable Tx Outcome Checks #1521

Closed DavePearce closed 2 days ago

DavePearce commented 1 week ago

The goal here is to undo the temporary fix in #1520. The problem is that a change in the BESU version (which fixed a bug with traceEndTransaction) has meant that all recorded tx outcomes are potentially invalid with respect to e.g. the sender. The temporary fix in #1520 simply disabled tx outcome checks. The goal now is to update the recorded tx outcome information so that the tests will pass with outcome checking enabled.

DavePearce commented 1 week ago

@letypequividelespoubelles Why did you close this? This is my reminder to fix the outstanding problems!

letypequividelespoubelles commented 1 week ago

sorry, my bad

DavePearce commented 1 week ago

[x] Include improved Capture Debugging
[x] Rename existing replay files
[x] Remove unused replay files
[x] Check diffs
[x] Copy over new replay files
[ ] Tag missed tests? LeosNewRanges and LeosNewRangesSplitTests
[ ] Test test test!