Consensys / mythx-cli

A command line interface for the MythX smart contract security analysis API
https://mythx-cli.readthedocs.io/
MIT License
83 stars 29 forks source link

Faulty payload source line endings #121

Closed dmuhs closed 4 years ago

dmuhs commented 4 years ago

Description

Python's file read function converts OS specific line endings to \n in the source code, and back to their equivalent when being written out. This results in a faulty payload submission to the API, where \n is given, but \r\n would be expected.

This bug does not affect the analysis quality. However, it can result in wrong source lines being counted (as a single character is stripped off).

dmuhs commented 4 years ago

Fixed in #123