search

Consensys / mythxjs

MIT License
26 stars 8 forks source link

clientToolName always "MythXJS" #25

Closed aquiladev closed 5 years ago

aquiladev commented 5 years ago

Initialazing client:

const mythx = new Client(address, pwd, 'remythx');

but when I call analyses there is default tool name

image

Gtonizuka commented 5 years ago

One of the option of the analyse object is toolName did you pass this value? https://github.com/ConsenSys/mythxjs/blob/master/src/index.ts#L15

https://github.com/ConsenSys/mythxjs/blob/master/src/apiServices/ClientService.ts#L191

Sorry this is probably confusing and should come from the top level (when instantiate the client). Will take in consideration for a refactor.

aquiladev commented 4 years ago

I still have the issue on "mythxjs": "1.3.5" Was it fixed?