search

Consensys / orion

Orion is a PegaSys component for doing private transactions
https://docs.orion.consensys.net/
Apache License 2.0
91 stars 43 forks source link

Remove port from nodeurl and clienturl (docs, sample config and examples) #419

Closed macfarla closed 3 years ago

macfarla commented 3 years ago

eg if you specify

nodeurl = "http://127.0.0.1:8888/"
nodeport = 7777

the url actually used will be http://127.0.0.1:7777 The examples, sample config and docs all make them the same eg

nodeurl = "http://127.0.0.1:8081/"
nodeport = 8081

same for clienturl/clientport

Should be eg

nodeurl = "http://127.0.0.1/"
nodeport = 7777
Shatakshi0805 commented 3 years ago

Hi, I would like to work on this issue.

Shatakshi0805 commented 3 years ago

Hello sir, I have created a pull request. In the pull request all the test cases have passed except one. The test case not passed are for the docker.md file, I made changes in the file according to the mentioned issue. can you please review it?

macfarla commented 3 years ago

Apologies for being ambiguous in the description. We still need the nodeport value but remove the port from the nodeurl value eg

nodeurl = "http://127.0.0.1/"
nodeport = 7777

I think if you make this change throughout, the docker step should pass.

vmichalik commented 3 years ago

@macfarla is this issue still relevant, or should it be closed?

macfarla commented 3 years ago

the easy workaround is to make them the same ie leave as is.