Consensys / web3signer

Web3Signer is an open-source signing service capable of signing on multiple platforms (Ethereum1 and 2, Filecoin) using private keys stored in an external vault, or encrypted on a disk.
https://docs.web3signer.consensys.net/
Apache License 2.0
201 stars 78 forks source link

Make vertx worker pool size configurable #920

Closed jframe closed 1 year ago

jframe commented 1 year ago

PR Description

Make vertx worker pool size configurable. Web3Signer uses the worker pool for signing requests. Increasing the size of the pool might help if there is a spike in signing requests.

It can be configured by using the hidden option --Xworker-pool-size --vertx-worker-pool-size option.

Default is set to the same the default in Vertx which is 20. See https://vertx.io/docs/apidocs/io/vertx/core/VertxOptions.html#DEFAULT_WORKER_POOL_SIZE

Fixed Issue(s)

Documentation

Changelog

Testing

jframe commented 1 year ago

LGTM. Do we need code to make the config and env vars work or is that just for the ATs?

That's just for ATs. We automatically get env and config through pico environment providers.