search

ConsumerDataStandardsAustralia / standards-maintenance

This repository houses the interactions, consultations and work management to support the maintenance of baselined components of the Consumer Data Right API Standards and Information Security profile.
41 stars 9 forks source link

EnergyPlanSolarFeedInTariff days field should be mandatory #449

Closed joe-aer closed 2 years ago

joe-aer commented 2 years ago

Description

The EnergyPlanSolarFeedInTariff.timeVaryingTariffs.timeVariations.days field is marked as optional when it should be mandatory.

With this field as optional along with the other timeVaryingTariffs optional fields, a time varying tariff can be configured without any element of time variation, i.e. a singleTariff.

Area Affected

This change will affect the EnergyPlanSolarFeedInTariff object returned by the Get Generic Plan Detail endpoint.

Change Proposed

The proposed change is for the days field to be marked as mandatory, both in documentation and in the Energy Swagger docs.

CDR-API-Stream commented 2 years ago

These changes have been staged for review: https://github.com/ConsumerDataStandardsAustralia/standards-staging/compare/release/1.16.1...maintenance/449

perlboy commented 2 years ago

This diff has been polluted with version bumps?

CDR-API-Stream commented 2 years ago

Apologies, the above compare link was incorrect. Here is the correct link: https://github.com/ConsumerDataStandardsAustralia/standards-staging/compare/release/1.17.0...maintenance/449

CDR-API-Stream commented 2 years ago

This change was incorporated into release v1.17.0. Refer to https://github.com/ConsumerDataStandardsAustralia/standards/issues/237 for further details.