ContactEngineering / ce-ui

User interface of contact.engineering
https://contact.engineering
MIT License
0 stars 0 forks source link

ENH: Attachments #62

Open IoannisNezis opened 3 months ago

IoannisNezis commented 3 months ago

This is the corrisponding PR for this PR in the main repo. When this is done there will be a viewer and editor for the attachments of surfaces and topographies. The new component will:

IoannisNezis commented 3 months ago

here is a snapshot of the work in progess: 20240320_16h50m08s_grim

If you have suggestions, dont hold back :)

pastewka commented 3 months ago

Looks good - @tdbjacobs, any thoughts and/or requirements regarding attachments?

tdbjacobs commented 3 months ago

Looks great!

But we should probably add a little explanatory text that attachments should not be raw data, but simply helper files that may be useful in evaluating the raw data (such as microscope images or other related (non-topography) content.

Also, do we need a "flag inappropriate content" button just in case some one misuses our attachments?

Also we should probably put a size limit so that it doesnt take up unreasonable storage

Tevis

Tevis Jacobs Mechanical Engineering and Materials Science University of Pittsburgh


From: Lars Pastewka @.> Sent: Thursday, March 21, 2024 5:35:09 PM To: ContactEngineering/ce-ui @.> Cc: Tevis Jacobs @.>; Mention @.> Subject: Re: [ContactEngineering/ce-ui] ENH: Attachments (PR #62)

Looks good - @tdbjacobshttps://github.com/tdbjacobs, any thoughts and/or requirements regarding attachments?

— Reply to this email directly, view it on GitHubhttps://github.com/ContactEngineering/ce-ui/pull/62#issuecomment-2013814267, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOUYWUUXI6VWGHYMIHOUULYZNHA3AVCNFSM6AAAAABE7XZWXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTHAYTIMRWG4. You are receiving this because you were mentioned.Message ID: @.***>

pastewka commented 3 months ago

Two comments:

Storage does not cost much but I agree that there should be some limit just to fight abuse.

pastewka commented 5 days ago

This looks good @IoannisNezis - no comments