search

ContentSquare / chproxy

Open-Source ClickHouse http proxy and load balancer
https://www.chproxy.org/
MIT License
1.28k stars 259 forks source link

[Feature] Change status code to concurrent query failed on cancelled requests #404

Closed NatSau02 closed 6 months ago

NatSau02 commented 7 months ago

Is your feature request related to a problem? Please describe. When sending concurrent queries with a syntax error, the response "500, concurrent query failed" is returned, although the clickhouse responds to such errors with 400 (screenshot). The same behavior is observed for requests with 404

Describe the solution you'd like 500 is a service error that requires attention and correction, I think it would be more accurate to return the status of the clickhouse response so that there are no differences and the response is more informative

Additional context Add any other context or screenshots about the feature request here.

image
NatSau02 commented 7 months ago

PR https://github.com/ContentSquare/chproxy/pull/405

mga-chka commented 7 months ago

FYI all the maintainers are a bit busy for the moment, we will review your 2 PR and issues next week

NatSau02 commented 6 months ago

https://github.com/ContentSquare/chproxy/issues/406 this solution was recognized as the best