search

ContextLab / hypertools

A Python toolbox for gaining geometric insights into high-dimensional data
http://hypertools.readthedocs.io/en/latest/
MIT License
1.81k stars 161 forks source link

Feature request: return projection matrix for hypertools.tools.procrustes? #217

Open hungtuchen opened 5 years ago

hungtuchen commented 5 years ago

In current implementation of hypertools.tools.procrustes, it only returns the aligned source matrix. I think it would be great if we can return the projection matrix so that we can use it to transform other data.

I am thinking (1) returning as a second output parameter (2) adding an option to let user choose if the projection matrix should be return (maybe default: False)

hungtuchen commented 5 years ago

If we agree on a solution, I am glad to work on it and submit a PR.

andrewheusser commented 5 years ago

@transedward - It's a good idea, but part of a larger revamping that would be required to keep the API consistent across all transformers (e.g. alignment, reduction etc). The way we've talked about doing this is saving out the entire transformation pipeline of fit models inside of a geo (the data object returned when hyp.plot() is called). Currently, the steps are saved, but the fit models are not.

Would you be interested in helping out with this? I think we have an existing issue with more details, let me see if I can find it..

andrewheusser commented 5 years ago

here's the issue: #161