search

Copterfly / modwsgi

Automatically exported from code.google.com/p/modwsgi
0 stars 0 forks source link

Close log files and daemon listener sockets which aren't needed. #94

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
A mod_wsgi daemon process can close off daemon listener sockets which are for 
other daemon 
process groups. 

A mod_wsgi daemon process if in VirtualHost can close off log files which are 
for a different virtual 
host. A global daemon process would still need to keep all open.

Not sure how easy it will be to work out what are unneeded log files. Can 
perhaps just scan 
server_rec structure list.

Original issue reported on code.google.com by Graham.Dumpleton@gmail.com on 5 Aug 2008 at 11:44

GoogleCodeExporter commented 9 years ago 
At revision 969 of trunk for 3.0, have made changes to close all daemon 
listener sockets in Apache worker 
processes, and all but own listener socket in mod_wsgi daemon process.

Original comment by Graham.Dumpleton@gmail.com on 6 Aug 2008 at 11:49

GoogleCodeExporter commented 9 years ago 
Discussion which triggered this is:

  http://groups.google.com/group/modwsgi/browse_frm/thread/fb8351095c31c699?hl=en

One thing that has come out of this is that wrong process ID is somehow being 
picked up and use for initial 
listener socket paths. Revision 971 addresses this by deferring point at which 
process ID factored into socket 
path.

Original comment by Graham.Dumpleton@gmail.com on 6 Aug 2008 at 12:29

GoogleCodeExporter commented 9 years ago 
Fix to changes in 981. Wasn't checking in Apache child processes that we 
actually had daemons before trying to 
close listener sockets for them. Was thus causing Apache child processes to 
crash when using embedded mode 
only.

Original comment by Graham.Dumpleton@gmail.com on 9 Aug 2008 at 12:30

GoogleCodeExporter commented 9 years ago 
Fixes to socket naming and closing of listeners in child process also 
backported to 2.2 at revision r982.

Deferred issue of whether to close log files. Will create a separate issue for 
log files later.

Original comment by Graham.Dumpleton@gmail.com on 22 Aug 2008 at 3:40

GoogleCodeExporter commented 9 years ago 
Version 2.2 release which closes listener sockets. As indicated, will create 
separate issue for closing log files if 
found it can be done safely.

Original comment by Graham.Dumpleton@gmail.com on 24 Aug 2008 at 5:58