search

Corewala / Buran

Gemini browser for Android
GNU General Public License v3.0
107 stars 10 forks source link

Color palette interface for picking background colors #31

Closed arielcostas closed 2 years ago

arielcostas commented 2 years ago

This pull request implements one of the features of the To-do list mentioned on the README.

Using a third-party package (licensed under the Apache License, there should be no legal issues) that shows a material bottom sheet with circles for each pickable color, that when clicked will save the new color as the background color picked for the app.

This PR includes also colors picked from the TailwindCSS project that are most adequate for background colors. ~However, it has the problem of not differenciating between light/dark mode, so a light color looks good on light mode, but will have little contrast when the app is set to dark mode. Perhaps this could be fixed by saving the colors somewhere else with light/dark color code and use one or another.~

Corewala commented 2 years ago

Unfortunately, part of the goals of this project is use a few external sources as necessary, so I'd rather not use an external package if I can get away with it. I haven't abandoned this project, but I'm getting set up at university so development will be happening more slowly over the course of the next little while.

arielcostas commented 2 years ago

Would it be better to implement it as part of the project itself? Instead of adding it as a dependency, reimplement the same feature.