search

CornellCAC / FortLua

Some code for use with CAC Virtual Workshop on Balancing Scripts and Compiled Code in Scientific Applications, https://www.cac.cornell.edu/VW/scripts/exercise2.aspx
0 stars 0 forks source link

New location for FortLua #1

Open kmanalo opened 9 years ago

kmanalo commented 9 years ago

Hi all I just noticed that I forked @adolgert 's FortLua version.

I would like to contribute a slight update that would modernize the project with Lua 5.2.3, is this the place to do it? There were a smaller number of changes, but I think it was related to a few functions. I have this updated in my fork, which I can submit if you are interested.

I have API changes that are primarily from https://bitbucket.org/haraldkl/aotus/wiki/Home, I wanted to stick with FortLua as it is pretty lean and the code was more accessible for my use case.

adolgert commented 9 years ago

Hi Kevin. That's great. @adambrazier has first dibs on the pull request if he wants it, because he's still working for Cornell's computing center. If not, I'm happy to merge into the adolgert FortLua.

kmanalo commented 9 years ago

Thanks, will wait for @adambrazier 's response.

kmanalo commented 9 years ago

Given the amount of time lapsed, please feel free to merge in.

I went the route of removing the attachment to the Ranger cluster, in the hopes of making this more useful to non-HPC users (though honestly I use it for HPC purposes).

Furthermore, I added in proper attribution to the Aotus team as per their MIT license, where most of the updates to the Lua bindings came from my modifications looking at their source code. I attached my name to the contributor listing in the README. My motivation for getting this working is to bind to a Gnuplot library in Lua, so that I can have a better glue for using Gnuplot within Fortran.

I plan on contributing this fork to https://github.com/Fortran-FOSS-Programmers - this may improve visibility with other extremely talented Fortran programmers.

I'd definitely like to know your thoughts - this ok?

kmanalo commented 9 years ago

Forgot that this is not @adolgert 's repository, I will create a pull request there if you want.

adolgert commented 9 years ago

Hi Kevin,

I looked through it, and thanks for your detailed work. I forgot about AOTUS, which was bad.

  1. If you send a pull request to https://github.com/adolgert/FortLua, then I’ll gladly take the whole pull request.
  2. If you want to be an owner on that project, I’ll happily add you, so that you have project control on the version that shows up first in a google search.

And, yes, I’m happy this was helpful, and I think we should keep it going. Fortran is great for some things, but I believe scientific software can be much better if we use the right tools for the job, and this is a little part of that.

Drew

On Jun 19, 2015, at 5:41 PM, Kevin Manalo notifications@github.com<mailto:notifications@github.com> wrote:

Forgot that this is not @adolgerthttps://github.com/adolgert 's repository, I will create a pull request there if you want.

— Reply to this email directly or view it on GitHubhttps://github.com/cornell-comp-internal/FortLua/issues/1#issuecomment-113651224.

kmanalo commented 9 years ago

Hi Drew,

Thanks I appreciate it; I've also been given authorization to push to the Fortran FOSS group so I'll be pushing the project there as well.

Regards, Kevin

On Mon, Jun 22, 2015 at 10:07 AM, Drew Dolgert notifications@github.com wrote:

Hi Kevin,

I looked through it, and thanks for your detailed work. I forgot about AOTUS, which was bad.

  1. If you send a pull request to https://github.com/adolgert/FortLua, then I’ll gladly take the whole pull request.
  2. If you want to be an owner on that project, I’ll happily add you, so that you have project control on the version that shows up first in a google search.

And, yes, I’m happy this was helpful, and I think we should keep it going. Fortran is great for some things, but I believe scientific software can be much better if we use the right tools for the job, and this is a little part of that.

Drew

On Jun 19, 2015, at 5:41 PM, Kevin Manalo <notifications@github.com mailto:notifications@github.com> wrote:

Forgot that this is not @adolgerthttps://github.com/adolgert 's repository, I will create a pull request there if you want.

— Reply to this email directly or view it on GitHub< https://github.com/cornell-comp-internal/FortLua/issues/1#issuecomment-113651224>.

— Reply to this email directly or view it on GitHub https://github.com/cornell-comp-internal/FortLua/issues/1#issuecomment-114144386 .