search

Cosmic-Chatter / Exhibitera

Free and open-source software for building and controlling museum exhibits.
MIT License
2 stars 2 forks source link

Media Browser Guided Setup #24

Open alexaverill opened 3 weeks ago

alexaverill commented 3 weeks ago

@forceflow1049 I wanted to split this off here since I think there is going to be some back and forth. I think its looking pretty good, but I ran into two bugs that made me unable to fun through the entire flow.

  1. Downloading the CSV template doesn't seem to be working at the moment, I am not seeing error logs anywhere. (I manually put a template together to upload)

  2. I got stuck on Upload Media, I had uploaded an image file that matched the name I had in the CSV, I am not seeing any errors at the moment. If you can't replicate it I can dig in more and see if I can isolate whats going on.

Some other really minor things:

  1. Add a way to delete languages after addition
  2. Add some spacing between the download and upload template buttons.

Simple Sample CSV I threw together

forceflow1049 commented 2 weeks ago

Great feedback @alexaverill—I have pushed a new commit that adds the ability to delete languages. Something I meant to add originally and just forgot... I also improved the button layout as you suggest.

I'm not sure why you can't download the template spreadsheet—what OS and browser are you using? The CSV downloads for me on Mac using both Safari and Edge.

Upload Media wasn't working for you because the app expects the spreadsheet to have a column named Media filename because that's what the template uses. I added a check that such a column actually exists (with a warning), in case someone else tries to upload their own CSV. But that's why you couldn't get past that even with the file uploaded. So it really all comes down to why the template won't download for you.

alexaverill commented 1 week ago

Sorry about the delay, been busy the last couple weekends. I was testing in the default webview that spawns when I start locally, since I am on a mac that should be safari under the hood. If I attempt to edit through a browser its still triggering the windows to open in the webview. Whats the correct config to get it to avoid that? I had set remote_display to true it disables the webview, but attempting to edit through a browser still results in the request hitting "POST /app/showWindow/media_player_setup" and nothing happening in the browser.

forceflow1049 commented 3 days ago

@alexaverill Did you save config / restart Exhibitera Apps after toggling remote display? I do virtually all my work on a Mac using Chrome / Safari and haven't had that happen.

alexaverill commented 1 hour ago

I think I must not have, I started again this morning from scratch and its working in when remote display is false.