CosmoStat / Shear-and-PSF-Reading-Group

Notes and tools derived from reading groups sessions
MIT License
2 stars 9 forks source link

[Bug] shrbk not found on Binder #29

Open sfarrens opened 3 years ago

sfarrens commented 3 years ago

The Bug

It appears that shrbk is not being built on Binder. e.g. I get the following error for the moments-basic notebook.

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-5bcbd37c88fe> in <module>
      1 # Import dependencies
      2 import numpy as np
----> 3 from shrbk.plot import *
      4 from shrbk.data import *
      5 from IPython.display import Markdown as md

ModuleNotFoundError: No module named 'shrbk'

Possible Cause

After reading this page it seems to me that the environment.yml is getting build priority over the setup.py.

"A list of supported configuration files (roughly in the order of build priority) can be found on this page (and to the right)."

Possible Solution

I propose to try adding a postBuild file with the following contents.

set -ex

# Install shrbk
python -m pip install -e .

@aboucaud any thoughts on this before I open a PR?

aboucaud commented 3 years ago

Very annoying!

Your solution is quite clean. Let's do that for now and see at some point if we can find a smoother way.