Open sfarrens opened 3 years ago
It appears that shrbk is not being built on Binder. e.g. I get the following error for the moments-basic notebook.
shrbk
moments-basic
--------------------------------------------------------------------------- ModuleNotFoundError Traceback (most recent call last) <ipython-input-1-5bcbd37c88fe> in <module> 1 # Import dependencies 2 import numpy as np ----> 3 from shrbk.plot import * 4 from shrbk.data import * 5 from IPython.display import Markdown as md ModuleNotFoundError: No module named 'shrbk'
After reading this page it seems to me that the environment.yml is getting build priority over the setup.py.
environment.yml
setup.py
"A list of supported configuration files (roughly in the order of build priority) can be found on this page (and to the right)."
I propose to try adding a postBuild file with the following contents.
postBuild
set -ex # Install shrbk python -m pip install -e .
@aboucaud any thoughts on this before I open a PR?
Very annoying!
Your solution is quite clean. Let's do that for now and see at some point if we can find a smoother way.
The Bug
It appears that
shrbk
is not being built on Binder. e.g. I get the following error for themoments-basic
notebook.Possible Cause
After reading this page it seems to me that the
environment.yml
is getting build priority over thesetup.py
.Possible Solution
I propose to try adding a
postBuild
file with the following contents.@aboucaud any thoughts on this before I open a PR?