search

CosmoStat / Shear-and-PSF-Reading-Group

Notes and tools derived from reading groups sessions
MIT License
2 stars 9 forks source link

Bias definition & measurement #43

Open martinkilbinger opened 3 years ago

martinkilbinger commented 3 years ago

A page on the definition of shear bias. Additive and multiplicative terms, population bias and individual bias.

A notebook to measure shear bias using the Pujol et al. (2017) method. Requires the shear_bias package.

thuiop commented 3 years ago

I finally took the time to properly review the PR. Overall this is a great addition to the book ; my main issue is with what scope we want to have for the book. At the moment, someone who does not know what shear is at all would be confused reading the shear bias page ; should we add an explanation of what it is, in that page or another ? In the same fashion, the word "calibration" is not defined. Concerning the "Measuring shear" page, I have nothing to add regarding the code itself, but I think it could use some more text between the code cells, to explain what is going on and make the link with the introduction. Also, the text mentions "several methods" for measuring shear while only 1 is presented, but I guess adding others will go in other PRs.

martinkilbinger commented 3 years ago

I finally took the time to properly review the PR. Overall this is a great addition to the book ; my main issue is with what scope we want to have for the book. At the moment, someone who does not know what shear is at all would be confused reading the shear bias page ; should we add an explanation of what it is, in that page or another ? In the same fashion, the word "calibration" is not defined. Concerning the "Measuring shear" page, I have nothing to add regarding the code itself, but I think it could use some more text between the code cells, to explain what is going on and make the link with the introduction. Also, the text mentions "several methods" for measuring shear while only 1 is presented, but I guess adding others will go in other PRs.

These are very good remarks. I can add some text to the notebook. I'll see what else is there in the book, it's been a while that I have not looked at it :)

In any case, the should be some place in the book that explains basic terms such as shear bias, calibration, etc.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB