Couchers-org / couchers

The next-generation couch surfing platform. Free forever. Community‑led. Non‑profit. Modern. Chuck us a star :)
https://couchers.org
MIT License
391 stars 78 forks source link

User search needs more filter options #4559

Open Krishnag09 opened 4 months ago

Krishnag09 commented 4 months ago

User search should allow the following filter criterion

I have only listed the filters we already have as part of user profile .

bakeiro commented 1 month ago

image

Checkboxes:

Rules

Other

bakeiro commented 1 month ago

image Notes: forget about the complicated slider, as is the first iteration, we'll do the simple one, the complicated one in the future

age_min age_max

bakeiro commented 1 month ago

image

should use

sleepingarrangement2api = {
    SleepingArrangement.private: api_pb2.SLEEPING_ARRANGEMENT_PRIVATE,
    SleepingArrangement.shared_room: api_pb2.SLEEPING_ARRANGEMENT_SHARED_ROOM,
}
bakeiro commented 1 month ago

378097920-8027a487-1fba-4f73-b406-6e6049173ea3

should use

hostingstatus2api = {
    HostingStatus.can_host: api_pb2.HOSTING_STATUS_CAN_HOST,
    HostingStatus.maybe: api_pb2.HOSTING_STATUS_MAYBE,
}

meetupstatus2api = {
    MeetupStatus.wants_to_meetup: api_pb2.MEETUP_STATUS_WANTS_TO_MEETUP,
    MeetupStatus.open_to_meetup: api_pb2.MEETUP_STATUS_OPEN_TO_MEETUP,
}
bakeiro commented 1 month ago

I will start working soon on the frontend changes :)

@Krishnag09 can you create for me the label smoking_allowed, it's just the only thing I'm missing on the backend right now...

jesseallhands commented 2 weeks ago

A few notes from the Safety & Trust team:

Sleeping Spaces

We cannot allow people to search specifically for shared sleeping spaces. We already have enough problems preventing people using the platform as a dating app/for sex, so we do not want to make it any easier by allowing people to specifically search for shared sleeping spaces (which people sometimes, incorrectly, assume means a shared sleeping surface).

We can keep "Type of room" and make the option of "private room" a radio button. That way if people really want their own private space, they can search for it (some people feel safer this way). The option to specifically search for a "shared space" should be removed. It's fine if it remains on the profile so people are aware when they are searching/reviewing profiles manually.

Has housemates

We should allow people to search for people with housemates. Some people feel safer staying with someone who has one or more housemates.

Gender

We will not allow users to search by gender. This is not only a men searching for women issue - it's also a men searching for other men issue! (believe me - I see the reports!) We do plan to eventually create "Host-A-Sister" mode to allow women to search for other women IF they complete strong verification first, but this is a future feature that has not yet been implemented or even fully designed.

nabramow commented 3 days ago

@bakeiro Is this the one you are abandoning? If so could you write a little summary here what's already done, what needs to be done and if there is a related PR already?

@Krishnag09 Is all the backend done for this?

bakeiro commented 3 days ago

@nabramow sure....

I basically implement the new filters in the frontend, all except the gender (since that one is more complicated, and needs strong verification etc)

a lot of filters are done in the backend, they just need the frontend implementation, here is my PR, I believe it's self explanatory, I recommended to not implement more filter than what I intenteded to (just to keep it simple, but this is only a recomendation)

my PR is this one https://github.com/Couchers-org/couchers/pull/5116

bakeiro commented 3 days ago

also, mind the memory @nabramow idk what happend, I just passed more props and the memory increased a lot (I'm not sure if it's something related with MUI, but just to tell you that increased a lot, plus I'm not sure why)

also I feel that I'm passing so much values by props, I though about using react.context, but idk... to decide by the next dev I guess!