CoxAutomotiveDataSolutions / waimak

Waimak is an open-source framework that makes it easier to create complex data flows in Apache Spark.
Apache License 2.0
75 stars 16 forks source link

Feature/using f bounded types #84

Closed vavison closed 5 years ago

vavison commented 5 years ago

Description

Using F-bounded types (https://tpolecat.github.io/2015/04/29/f-bounds.html) instead of using this.type which has been causing us problems for a long time.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Existing tests are all passing

codecov-io commented 5 years ago

Codecov Report

Merging #84 into develop will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
- Coverage    82.12%   82.11%   -0.02%     
===========================================
  Files           56       56              
  Lines         1600     1599       -1     
  Branches        63       63              
===========================================
- Hits          1314     1313       -1     
  Misses         286      286
Impacted Files Coverage Δ
...autodata/waimak/dataflow/spark/SparkDataFlow.scala 87.32% <100%> (ø) :arrow_up:
...a/waimak/dataflow/spark/ParquetDataCommitter.scala 98.33% <100%> (ø) :arrow_up:
...ala/com/coxautodata/waimak/dataflow/DataFlow.scala 95.58% <100%> (-0.04%) :arrow_down:
...coxautodata/waimak/dataflow/DataFlowExecutor.scala 96.96% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0df6784...c93c1f5. Read the comment docs.