search

CptOblivion / Cisco-Codec-Controller

4 stars 1 forks source link

overwrite binding doesn't release #43

Closed nottooloud closed 3 years ago

nottooloud commented 3 years ago

I expected to hold down overwrite and press a preset button to overwrite it. However, since pressing overwrite, every preset button is an overwrite. How do I turn it off? I notice it opened the edit presets window in the app. Locking that didn't stop it. Activating from the app still works, but anything I pick from the controller is reset to current.

CptOblivion commented 3 years ago

Debugging time: map a button of the midi pad to debugOutputValue (under the debug binding category), and then in the program press it a few times and paste in what prints to the terminal- we should either be seeing True when you press it and then False when you release, or a number greater than zero when you press it and then zero when you release

nottooloud commented 3 years ago

Yeah, nothin but True all day.

nottooloud commented 3 years ago

So this controller won't do that.

nottooloud commented 3 years ago

True on press, True on release. Also sometimes True in between, these contacts aren't very good.

CptOblivion commented 3 years ago

I'm gonna have to write a slightly more robust debugging function that prints out a little more information, I'll get to it after I acquire caffeine and food

nottooloud commented 3 years ago

Mapped overwrite to the xBox Xbox button, and that works as expected, once I told Windows not to call up the xbox toolbar I didn't know existed.

CptOblivion commented 3 years ago

My current working theory is that the midi pad is sending "note on" with velocity 0, instead of "note off"- I should be treating velocity 0 notes as off anyways

CptOblivion commented 3 years ago

Implemented the velocity 0 thing, hopefully that sorts it out! (if it doesn't, I'll rework the debug command and we'll see what's going on)