search

CraigBryan / property-rental-system

This is a group project for SEG 3102 in Fall 2014.
MIT License
3 stars 1 forks source link

Footer on Add Property Page and Create New User not at the bottom #16

Closed charle692 closed 10 years ago

charle692 commented 10 years ago

The footer is not pushed all the way to the bottom of the page.

CraigBryan commented 10 years ago

I'm not sure what you mean. The footer (where it says "Hi WHOEVER") looks like it's at the bottom. I have to scroll down to see it there.

CraigBryan commented 10 years ago

Nevermind. I pulled and I definitely see it now.

katdrobnjakovic commented 10 years ago

check out: http://getbootstrap.com/examples/sticky-footer/

CraigBryan commented 10 years ago

Ok. I pushed a fix.

The trick was to set the footer to be position:fixed (same place in the viewpoint all the time). Then, because this would make the bottom of the page covered by the footer (since position: fixed takes it out of the normal document flow and therefore we can't scroll far enough down to see the very bottom) I had to add a spacer div at the very bottom of _footer.html.erb that was the same height (actually slightly bigger) as the footer, so we can always scroll such that we can see the entire page content.