Upgrade lerna - Githubissues

CraveFood / farmblocks

React components for building web projects.

https://cravefood.github.io/farmblocks/

MIT License

20 stars 5 forks source link

Upgrade lerna #512

Closed fczuardi closed 6 years ago

fczuardi commented 6 years ago

Just accepting the greenkeeper bot PR was not enough to get us on the new lerna version and so we reverted in #510

This issue is about making the necessary changes on our build system in order to be able to use lerna 3

fczuardi commented 6 years ago

lerna 3 also breaks our commitzen adapter, see https://github.com/atlassian/cz-lerna-changelog/issues/16 the workaround for this would be to change our commitizen adapter to something that is not an abandoned project, cz-conventional-changelog maybe

fczuardi commented 6 years ago

and canary version numbers dont play well with yarn publish, so we would have to use --npm-client npm on the publishing commands as a workaround see https://github.com/yarnpkg/yarn/issues/6313

fczuardi commented 6 years ago

In summary, to make the move to lerna3 we would have to fix those 3 things:

the original issue about uncommitted changes (this should be simple, it is being caused by a travis_wait logfile, we can add it to the .gitignore)
use npm to publish (we can keep using yarn for everything else)
switch our commitizen adapter to something that is well maintained