Crazy-Marvin / FucksGiven

Count How Many Fucks You Give ๐Ÿ–•
https://crazymarvin.com/fucks-given/
Apache License 2.0
103 stars 10 forks source link

Added Password Protection and biometric authentication by Encrypted Shared Preferences and biometrics in android #125

Closed anuragkanojiya1 closed 1 month ago

anuragkanojiya1 commented 1 month ago

Related Issue

Closes: #115

Description

Implemented the password protection feature using encrypted shared preferences. This ensures that sensitive user data is securely stored in an offline mode and accessed only through proper authentication. Added logic to enable and disable password protection, and updated the settings screen to reflect the current state of the password protection feature.

Type of Change

https://github.com/user-attachments/assets/3d63c8f8-298a-426f-9710-4e43fe14232b

CrazyMarvin commented 1 month ago

This is awesome! Thank you very much for your input, @anuragkanojiya1. ๐Ÿ‘

Would it be possible to use biometrics instead of a password too?

May you please make the new strings translateable (android/app/src/main/res/values/strings.xml )?

Can you please have a look too, @mubeen1519? What do you think?

mubeen1519 commented 1 month ago

sure will look into it but biometric feature are good approach for this app and convinent for user

mubeen1519 commented 1 month ago

actually its looks not too good to use password and this design also if biometric option is available we dont need to do this stuff only prompt show at start for biometric and user dont need to write and remember the password

anuragkanojiya1 commented 1 month ago

Okay, I will try to make a PR regarding biometric authentication soon.

CrazyMarvin commented 1 month ago

I think both options would be great. So the users can decide if they go without extra protection, password or biometrics.

CrazyMarvin commented 1 month ago

Thanks for giving a helping hand, @mubeen1519! โค๏ธ

anuragkanojiya1 commented 1 month ago

I think both options would be great. So the users can decide if they go without extra protection, password or biometrics.

Okay @CrazyMarvin

anuragkanojiya1 commented 1 month ago

@CrazyMarvin I have implemented biometric auth and tested it on my physical device, it is working fine, you should check it out too.

CrazyMarvin commented 1 month ago

May you share a debug APK please, @anuragkanojiya1? May you please review the code, @mubeen1519?

anuragkanojiya1 commented 1 month ago

@CrazyMarvin Here's the debug apk.

debug.zip

anuragkanojiya1 commented 1 month ago

@CrazyMarvin any update?

mubeen1519 commented 1 month ago

@CrazyMarvin Here's the debug apk.

debug.zip

the apk is not installing on my device android 10

anuragkanojiya1 commented 1 month ago

@CrazyMarvin Here's the debug apk.

debug.zip

the apk is not installing on my device android 10

It's working fine on my Android 10 device.

Screenshot_20241018-132213.jpg

Screenshot_20241018-132150.jpg

Screenshot_20241018-132314.jpg

CrazyMarvin commented 1 month ago

I just merged your PR.

The UX needs a bit fine-tuning. Are you interested to do that next week?

Thanks!

anuragkanojiya1 commented 1 month ago

I just merged your PR.

The UX needs a bit fine-tuning. Are you interested to do that next week?

Thanks!


Sure @CrazyMarvin, Iโ€™d love to connect with you on LinkedIn. You can find my profile here: Anurag Kanojiya.

Additionally, if you enjoy my work and would like to support me, you can check out my GitHub Sponsors profile: Sponsor My Work. Your support would mean a lot to me!

Looking forward to contribute more!

Best regards,
Anurag Kanojiya


CrazyMarvin commented 1 month ago

The designer updated the mockup. Are you able to create a new PR that reflects it, @anuragkanojiya1?

anuragkanojiya1 commented 1 month ago

The designer updated the mockup. Are you able to create a new PR that reflects it, @anuragkanojiya1?

Sure @CrazyMarvin.