search

CrisisCleanup / crisiscleanup-2

[OLD] This version of the codebase was retired on March 27, 2020. Open Source Collaborative Disaster Recovery and Cleanup
https://www.crisiscleanup.org
Other
42 stars 24 forks source link

Add phone2 to printed work order #465

Closed aarontitus closed 5 years ago

hlygrail commented 5 years ago

You’ve got duplicate phone#2 in your change (#465):

<%= @site.phone1 %>  |  <%= @site.phone2 %><%= @site.data["phone2"] %>

I’m not sure what the new site.data part is (I assume it’s a new array), but whatever you do for phone2, you also need to do for phone1, I assume. So it should probably look like this (also adding another space between the bar):

<%= @site.phone1 %><%= @site.data["phone1"]    |    <%= @site.phone2 %><%= @site.data["phone2"] %>

(But wouldn't that end up showing FOUR phone numbers, though? Or is it such that a phone# can only exist in site.phone1 or site.data[phone1], but not both?)

aarontitus commented 5 years ago

The phone2 column is picky. In previous versions, phone2 was placed in the data column as a part of an hstore array. But during an update we moved phone2 to a top-level column. Basically that means that for some cases, phone2 is extracted from data, while sometimes it is extracted from the top level. But never both. So that's why I placed them side-by-side. And phone1 was never in the data column. Yeah, old... messy...