search

Crocoblock / suggestions

The suggestions for CrocoBlock project
196 stars 79 forks source link

JetEngine - User Profile Builder - 'Disable Admin Bar For Non-Admins' Blocks Admin Bar For Editor Role #7837

Closed rtpHarry closed 3 weeks ago

rtpHarry commented 4 weeks ago

Describe the bug If you enable this in the JetEngine User Profile settings screen:

image

Then the admin bar disappears for the Editor role.

I consider Editor to still be a site administrator role, based on the definition that they use the admin bar / and admin panel as part of their tasks.

Looking at the code, it seems the issue is because its checking for manage_options:

image

So this means that if you're using this you have to choose between showing the admin bar to public users of the User Profile feature, or disable it for Editor role, woo Shop Manager role, and even Author / Contributor.

I think this needs some fine tuning, with a better UI, but in the short term, consider at least making it filterable for power users to customise?

MjHead commented 3 weeks ago

@rtpHarry Admin (Administrator) and Editor is a different roles in WP. Anyway, if you need more precise control on this - you can do it manually from the code, without using this switcher. If we'll add an ability to change behavior of this switcher with some hooks, the result by difficulty of use will be the same as disabling admin bar programmatically with some code-snippet. For example like this - https://themeisle.com/blog/hide-wordpress-admin-bar/#hiding-for-user-role (section b) Using code)