Crossroads-Development / Crossroads

Crossroads is a mod for Minecraft. It adds a lot of content, and has the design philosophy of "simple pieces, complex contraptions".
MIT License
29 stars 18 forks source link

Valkryien Skies compat #273

Open The-Minecraft-Scientist opened 5 months ago

The-Minecraft-Scientist commented 5 months ago

Suggestion compatibility with the Valkyrien Skies mod

Justification it'd be nice. If not, I'll just distribute a fork Alternative Alternatively, I could stick all of this custom logic in a Crossroads addon, but I'm not sure how straightforward that will be. It'd probably involve at least a bit of mixing in to Crossroads; the feasibility of this idea depends mostly on how much logic I'd have to clobber with mixins.

Caveats Building against the forge version of an Architectury multiplatform mod (Valkyrien Skies) with ForgeGradle is really jank. Compiling works fine but due to remapping issues that I don't quite understand, the ForgeGradle test client (runClient) is broken unless you do some really dumb hackery, so if we ever merge VS compat into main, we'll want the dependency to be compileOnly by default to avoid breaking peoples dev environments

Additionally, I haven't yet tried building Crossroads against VS, so there could be even more Gradle jank hiding there for me to discover