search

CrowdHailer / Ace

HTTP web server and client, supports http1 and http2
https://hex.pm/packages/ace
MIT License
305 stars 26 forks source link

Add type information #143

Open varnerac opened 4 years ago

varnerac commented 4 years ago

Type all the things. Minor refactors.

varnerac commented 4 years ago

Any thoughts on this?

CrowdHailer commented 4 years ago

This is good. Would be good to be able to Run dialyzer against it in travis

CrowdHailer commented 4 years ago

@varnerac can you merge the latest master into this branch.

Then have a look if dialyzer passes. https://travis-ci.org/github/CrowdHailer/Ace/pull_requests

I see a few errors on master but wonder if the improved type information on here will clear them up. The errors I have are 

lib/ace/governor.ex:37: Function init/1 has no local return
lib/ace/governor.ex:64: Function start_server/1 has no local return
varnerac commented 4 years ago

Will do