Community TableView Header, Contact Leaders Button, filtering groups

CruCentralCoast / CruiOS

iOS mobile app for Cru Central Coast. NOTE: The app has been decommissioned and this repo has been archived

1 stars 2 forks source link

Community TableView Header, Contact Leaders Button, filtering groups #189

Closed landongerrits closed 6 years ago

landongerrits commented 6 years ago

Currently the groups are not being filtered into the correct header, I'm still working on that

But if anyone wants to take a look feel free to, I will continue working on this throughout the weekend

I also will be doing smaller UI improvements

cbatch commented 6 years ago

yo can you post screenshots

landongerrits commented 6 years ago

I can't figure out why the section header is being indented by a single space.

Also I am reworking the layout of the detail screen. Just use that screen as reference for what information we will be displaying

landongerrits commented 6 years ago

whoops did not mean to close the PR, just reopened

cbatch commented 6 years ago

Suggestions

I'd try making the "Leader" text all caps, and bring it closer to the actual leader names
I wouldn't append "Community Group" to the end of the leaders names, keep it to just the leader names
make the padding on the left of the cells be the same as the section headers (I don't think it's being indented by a space, I just think your cell text is too far left, it's more left than the line beneath it)
I'd put a | between the gender and meeting time
I'd make the font weight of the leader names and subtext match what's going on in the resources view for consistency
I'd put a disclosure indicator on these cells since they'll push on a detail view

landongerrits commented 6 years ago

landongerrits commented 6 years ago

I have community group searching working for all labels. It feels a little hacky in code with transforming arrays into dictionaries. I'll continue to work on finding a cleaner way to do it, but this works as it is.

should I display section headers like this when searching?

any other critiques/feedback?

landongerrits commented 6 years ago

I think ideally we only see the section header if items are contained within that "day" otherwise it should be hidden

cbatch commented 6 years ago

yeppp, I'd say only show section headers if there are results

cbatch commented 6 years ago

it's still not clear what the names are for in this view
I'd try not putting the subtext in all caps, it's probably differentiated enough without, it looks weird when inline with the time when they're all caps

landongerrits commented 6 years ago

Section headers are now hidden if no groups are found for those days when searching

made changes to cell subtext as per @cbatch's comment

tydahlwave commented 6 years ago

Good to merge. A good habit is to reference which issues you closed in this PR or to reference this PR from the issues when you close them. If you use the phrase "Closed" or "Fixed" in front of "Pull Request" or "Issue" and followed by the # and number, GitHub will automatically link them

landongerrits commented 6 years ago

Closed Issue #198 - searching for community groups

merging in and closing Pull Request