Cubxity / typstudio

A W.I.P desktop application for a new typesetting language, typst.
GNU General Public License v3.0
611 stars 19 forks source link

Improve file explorer #2

Closed OlshaMB closed 1 year ago

OlshaMB commented 1 year ago

I want to improve file explorer usability

Roadmap

OlshaMB commented 1 year ago

@Cubxity what icons do you use for typstudio?

Cubxity commented 1 year ago

Hi, thank you for contributing! Please mark the PR as draft if this is still W.I.P. Also, typstudio uses pnpm, please remove yarn.lock from the PR.

Cubxity commented 1 year ago

@Cubxity what icons do you use for typstudio?

Material Icons.

OlshaMB commented 1 year ago

Ok i will remove yarn.lock

OlshaMB commented 1 year ago

@Cubxity what icons do you use for typstudio?

Material Icons.

Sidequestion: shouldn't you credit them?

OlshaMB commented 1 year ago

I think the pr is done. I also needed to add confirm dialog to ask before deletion.

Cubxity commented 1 year ago

Hey, can you rebase and resolve the conflicts?

OlshaMB commented 1 year ago

I believe that creating directories and files should be hidden in a context menu. This removes clutter from the UI. Same goes for deletion.

@Cubxity Maybe show the icons only on hover? This also will remove clutter, but unlike a context menu you would feel that you are creating it on a directory not on a file explorer

Cubxity commented 1 year ago

I believe that creating directories and files should be hidden in a context menu. This removes clutter from the UI. Same goes for deletion.

@Cubxity Maybe show the icons only on hover? This also will remove clutter, but unlike a context menu you would feel that you are creating it on a directory not on a file explorer

That sounds alright.

Csega commented 1 year ago

Hi Guys!

What is the status of this PR? Can you comment on it? Is it still in progress or just hanging?

Cheers, Csega

OlshaMB commented 1 year ago

I am busy right now so the pr is a hanged for now but I think I will return to this pr this weekend and finish it.

caoimhebyrne commented 1 year ago

Are you continuing this PR @OlshaMB?

OlshaMB commented 1 year ago

yes

OlshaMB commented 1 year ago

@caoimhebyrne Done

Cubxity commented 1 year ago

Could you rebase/resolve conflicts?

caoimhebyrne commented 1 year ago

@OlshaMB are you planning on continuing to maintain this PR? If not, please let us know ☺️

OlshaMB commented 1 year ago

@OlshaMB are you planning on continuing to maintain this PR? If not, please let us know ☺️

No, I am not planning, I am not interested in typst right now(waiting for html output) and there are too much changes to merge

caoimhebyrne commented 1 year ago

Ok, I will close the PR and open an issue for improving the file explorer.