search

Curt-Park / rainbow-is-all-you-need

Rainbow is all you need! A step-by-step tutorial from DQN to Rainbow
MIT License
1.87k stars 334 forks source link

fix:gamma was not correctly passed in for replay buffers #66

Closed DaivdYuan closed 1 year ago

DaivdYuan commented 1 year ago

The agent gamma should also be passed into the replay buffer. The previous version did not perform well in practice (I am using it in my research)

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Curt-Park commented 1 year ago

@allcontributors please add @DaivdYuan for code

allcontributors[bot] commented 1 year ago

@Curt-Park

I've put up a pull request to add @DaivdYuan! :tada: