search

CustodesTechnologia / System

The repository devoted to plan, organize and execute work items pursuant to the System
0 stars 2 forks source link

Signatures missing? #34

Closed sibomots closed 2 years ago

sibomots commented 2 years ago

Signature capabilities not in current SW?

Check.

sibomots commented 2 years ago

So here is the resolution --

I am not trying to pick on this user, but I'm using their signature for an example. The raw data in the database is as follows:

[url="http://www.bolterandchainsword.com/topic/353158-mandragola%E2%80%99s-legio-cultura/"]Titanic Plog[/url]. Should really be painting [url="http://www.bolterandchainsword.com/topic/353527-mandragolas-crimson-fists/"]Crimson Fists[/url].<br />[img]http://image.bolterandchainsword.com/uploads/gallery/album_15151/gallery_48988_15151_9524.png[/img][img]http://image.bolterandchainsword.com/uploads/gallery/album_12339/gallery_45765_12339_6416.png[/img][img]http://image.bolterandchainsword.com/uploads/gallery/album_16045/gallery_48988_16045_14557.png[/img][img]http://image.bolterandchainsword.com/uploads/gallery/album_16308/sml_gallery_48988_16308_6255.png[/img]

There are two Codes that need to be changed.

Here is the first change.

[url=X] Y [/url]

will change to this: <a href="X">Y</a>

That will be done via script automagically.

The next change:

[img]URL[/img]

changes to:

<img alt="URL" class="ipsImage" src="URL" />

The compromise that has to be made is that the SW provides attributes to the <img> tag that are difficult to automatically acquire (doable, but a pain in the ass)... The actual <img> tag is this:

<img alt="gallery_48988_15094_7420.png" class="ipsImage" data-ratio="66.67" 
height="100" width="150"
src="https://image.bolterandchainsword.com/uploads/gallery/album_15094/gallery_48988_15094_7420.png" />

The attributes to the img tag missing are data-ratio, height, width.

Browsers gain from height and width to prepare the visual real-estate in the browser. data-ratio along the same line.

It could be done that the script gets the geometry of the image (each image) if the URL is local to the site. It's not a requirement.

So, those are the two main scrub operations to do with this Issue.

`

Brother-Tyler commented 2 years ago

Ultimately, this issue relates to the custom BBCode issue; and resolving the custom BBCodes will (should) resolve the signatures.

The report was initially made when signatures were turned off (because of the problem the BBCode is creating).

sibomots commented 2 years ago

Signatures work. But the content is affected by the BBCode scrub. The scrub is already handled in a ticket. I'm closing this resolved.