Cxbx-Reloaded / XbSymbolDatabase

Xbox Symbol Database library
MIT License
23 stars 10 forks source link

TASK: Rename identical OOVPAs to parameter format method #6

Open RadWolfie opened 6 years ago

RadWolfie commented 6 years ago

I am seeing a few has something not acceptable format as example provided below.

both are main functions except also different old/new revision call

What's not acceptable is:

What's really acceptable is:

Reason?

jarupxx commented 6 years ago

Looks like subroutines called from the main function.

So, acceptable add a parameter Example@xx, Example2@xx to use these functions. Taking format into consideration, not acceptable the D3DDevice_BeginPush2, I think.

RadWolfie commented 6 years ago

Revised explanation clearly to meant both Example and Example2 are main functions.

If a main function has same name as sub routine, then Example2 as sub routine is correct. Except really need to add a note above plus XREF flag too.

Also, if both main and sub routine has more/less arguments. Then we need to insert X*4 afterward to be familiar with what's the real difference in the future.